Skip to content

Fix hardcoded urls#283

Merged
FelixFrizzy merged 1 commit intodevelopmentfrom
fix-urls
Sep 5, 2025
Merged

Fix hardcoded urls#283
FelixFrizzy merged 1 commit intodevelopmentfrom
fix-urls

Conversation

@FelixFrizzy
Copy link
Copy Markdown
Collaborator

@FelixFrizzy FelixFrizzy commented Sep 5, 2025

  • prevented using reverse proxy and custom url slugs

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the “create account” link on the login page to reliably route to signup.
    • Corrected the login link on the password reset completion page for consistent navigation.
    • Ensured team links in the teams view reliably open the correct team pages.
    • Overall, navigation links are more robust and less likely to break with future URL updates.

- prevented using reverse proxy and custom url slugs
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 5, 2025

Walkthrough

Replaced hard-coded href paths with Django URL reversing tags in three templates: login, reset password complete, and teams list. Links now reference named routes: signup, login, and teams with parameter. No other markup or logic changes.

Changes

Cohort / File(s) Summary of changes
Auth templates URL reverse updates
evoks/theme/templates/login.html, evoks/theme/templates/reset_password_complete.html
Changed href="/signup" to href="{% url 'signup' %}" and href="/login" to href="{% url 'login' %}".
Teams template URL reverse update
evoks/theme/templates/teams.html
Replaced href="/teams/{{team.name}}" with href="{% url 'teams' team.name %}".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c512f0b and 086018a.

📒 Files selected for processing (3)
  • evoks/theme/templates/login.html (1 hunks)
  • evoks/theme/templates/reset_password_complete.html (1 hunks)
  • evoks/theme/templates/teams.html (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test-all
🔇 Additional comments (3)
evoks/theme/templates/login.html (1)

28-28: Excellent implementation of Django URL reversing!

The change from hard-coded /signup to {% url 'signup' %} properly implements Django's URL reversing pattern, making the application more maintainable and compatible with reverse proxies and custom URL configurations.

evoks/theme/templates/teams.html (1)

70-70: Perfect Django URL reversing implementation with parameter!

The change from hard-coded /teams/{{team.name}} to {% url 'teams' team.name %} correctly implements Django's URL reversing with a parameter. This ensures the URL pattern remains flexible and works properly with reverse proxies.

evoks/theme/templates/reset_password_complete.html (1)

25-25: Clean Django URL reversing implementation!

The change from hard-coded /login to {% url 'login' %} follows Django best practices and aligns perfectly with the PR objective of fixing hardcoded URLs.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-urls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.35%. Comparing base (c512f0b) to head (086018a).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #283   +/-   ##
============================================
  Coverage        92.35%   92.35%           
============================================
  Files               50       50           
  Lines             1845     1845           
============================================
  Hits              1704     1704           
  Misses             141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FelixFrizzy FelixFrizzy merged commit c29682d into development Sep 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant