Skip to content

Add tests for Describe() method#41

Merged
cs168898 merged 3 commits intokishyassin:mainfrom
akshayhat:feature/describe-method
Jan 16, 2026
Merged

Add tests for Describe() method#41
cs168898 merged 3 commits intokishyassin:mainfrom
akshayhat:feature/describe-method

Conversation

@akshayhat
Copy link
Copy Markdown
Contributor

@akshayhat akshayhat commented Jan 14, 2026

Closes # 32
This PR adds unit tests for the new Describe() method.

  • Covers numeric columns (int, float64)
  • Ensures non-numeric columns are ignored
  • Validates mean calculation

This helps verify dataframe summary behaviour similar to pandas describe().

Copy link
Copy Markdown
Collaborator

@cs168898 cs168898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation, just optional minor changes.

Comment thread dataframe/dataframe.go Outdated
Copy link
Copy Markdown
Collaborator

@cs168898 cs168898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the testing file, small changes have to be made, but other than that its good implementation. If you have the time, please add tests for count, min and max as well! Great job 😊

Comment thread dataframe/describe_test.go Outdated
@akshayhat akshayhat requested a review from cs168898 January 15, 2026 18:45
@cs168898 cs168898 merged commit 8d98b70 into kishyassin:main Jan 16, 2026
1 check passed
@cs168898
Copy link
Copy Markdown
Collaborator

cs168898 commented Jan 16, 2026

closes #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants