Add support for SSO(Single Sign-On)#22
Open
brunoosilva wants to merge 13 commits into
Open
Conversation
Owner
|
Hey! Could you please also remove the travis configuration for bower and make sure that the tests pass. |
Owner
|
Since im not currently maintaining this plugin anymore I also added you to contributors list. However with that in mind, could you please not bump the version for stuff unless its released to master. Pumping in pull-requests is a anti-pattern that we should overall avoid. Other than that, good job and enjoy. |
Collaborator
Author
|
Hy @kirstein, Thanks for the comments and add me in contributors list. I forgot "Travis" has corrected and went. Now I do not understand about the versions and pull-request. Sorry I'm starting in the world of open-source :) |
brunoosilva
force-pushed
the
master
branch
2 times, most recently
from
9da0655 to
2482a96
Compare
added 2 commits
October 10, 2016 09:19
Collaborator
Author
|
Strange, I moved to the current version and the breaking test at Travis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Added support for SSO, for more information https://help.disqus.com/customer/portal/articles/236206-single-sign-on
Removed bower, because is not necessary.
Also, published in http://npmjs.com.
Url of package: https://www.npmjs.com/package/angular-disqus