Skip to content

Fix c++ compilation failure #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
twells46 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix c++ compilation failure #600

twells46 wants to merge 2 commits into from
+74 −21

Conversation

@twells46
Copy link
Contributor

@twells46 twells46 commented Nov 24, 2025

Previously, the /compile route wrote to a .c file and compiled with emcc, which caused Emscripten to try to compile user code as C even if it was C++. This patch:

  • Names the files with the correct extension.
  • Calls em++ instead of emcc when language is C++.
  • Fixes simMainWrapper in C++.
  • Fixes incorrect libkipr import in C++.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 24, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcorbly tcorbly Awaiting requested review from tcorbly

@erinharrington-12 erinharrington-12 Awaiting requested review from erinharrington-12

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twells46 @tcorbly