digitalPin: do not export if the /sys/class/gpio/... file already exists#61
Closed
SpComb wants to merge 2 commits intokidoman:masterfrom
Closed
digitalPin: do not export if the /sys/class/gpio/... file already exists#61SpComb wants to merge 2 commits intokidoman:masterfrom
SpComb wants to merge 2 commits intokidoman:masterfrom
Conversation
Open
Contributor
|
I've taken a slightly different approach in #67, which is to ignore the error if the pin has already been exported. This way it's only one system call. |
Author
|
That sounds like it would also work just as well. |
Contributor
|
I used to workaround catching os signal, and unexporting in init through cmd.exec |
Contributor
Contributor
|
@tve I meant to say was my workaround to handle unexported GPIO issue
|
Contributor
|
I'm pretty convinced that this is taken care of by #69. Please reopen with an example if it's not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change digitalPin to allow the use of an already exported gpio pin, avoiding the
write /sys/class/gpio/export: device or resource busyerrors that currently result. This kind of situation is easy to end up in if you e.g. kill the process and restart it, without giving it a chance to unexport its pins.This should suffice to handle the issues mentioned in #30 and #44.
This also helps to deal with the
open /sys/class/gpio/gpio21/direction: permission deniedraces in #52, by allowing us to use a helper script to pre-export the gpio pins and wait for udev to settle.