Add basic support for INA219 current sensor#58
Open
fluffy wants to merge 3 commits intokidoman:masterfrom
Open
Add basic support for INA219 current sensor#58fluffy wants to merge 3 commits intokidoman:masterfrom
fluffy wants to merge 3 commits intokidoman:masterfrom
Conversation
Contributor
|
Hi, I don't know whether you are at all interrested in getting this merged in. If so, I think it could do with some docs/comments... |
Author
|
I sort of assumed this project was dead after not hearing anything since last May but glad to see you are moving it forward. Do you have an similar sort of sensor file that might form a guideline for what would be needed ? I'd be glad to see this get merged in but total only want to put time into it if I know that is going to happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I like the embd library and added support for INA219 current sensor. I have only tested on a Pi but given it only uses the I2C calls, it seems fairly likely it will work on all the platforms. I will probably do some polish on this but wanted to send it your direction for an early review and see if you had any suggestions. I tried to keep it in the style of the other sensors.
Thanks, Cullen