Open
Conversation
…ull request accepted in the origin
Contributor
|
@zlowred I know your PR is a few months old.... would you mind commenting on using the (very nice) one-wire support you built vs. using kernel drivers for the devices? For example, your sample shows use of the ds18b20 sensor but the w1-therm kernel driver does that too and could be used instead. |
Author
|
Built in driver doesn't allow to set resolution, save config etc. while mine does. That's the only difference if I remember correctly. |
Contributor
|
Ah. You can actually set the resolution with the driver, but it applies to all ds18b20 sensors. Thanks for the clarification! |
|
Can this be merged? Could use. |
Owner
|
Yea I will look at it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.