Skip to content

Add linting config and Github Action workflow #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khubaibras merged 9 commits into from
Jun 22, 2025
Merged

Add linting config and Github Action workflow #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edae450
Add linting config and Github Action workflow
khubaibras Jun 22, 2025
49af578
Add valid HTML and CSS files for Home page
khubaibras Jun 22, 2025
abba305
Fix stylelint config by adding standard preset
khubaibras Jun 22, 2025
f387e1d
Update workflow to fix Stylelint rule error
khubaibras Jun 22, 2025
aa25f94
Fix use npx to run stylint correctly
khubaibras Jun 22, 2025
e6c195f
Fix: update CI workflow and Stylelint config
khubaibras Jun 22, 2025
403a762
Fix: update Styles
khubaibras Jun 22, 2025
b6f78ad
Fix empty CSS file with proper content
khubaibras Jun 22, 2025
bf6a901
Fix stylelint config and rules
khubaibras Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/ci-develop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: CI for Develop Branch

on:
pull_request:
branches: [ develop ]

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: '18'

- name: Install HTMLHint
run: npm install -g htmlhint

- name: Install Stylelint and Config
run: npm install -g stylelint stylelint-config-standard

- name: Lint HTML files
run: |
if ls src/*.html 1> /dev/null 2>&1; then
htmlhint src/*.html
else
echo "No HTML files found to lint"
fi

- name: Lint CSS files
run: |
if ls styles/*.css 1> /dev/null 2>&1; then
stylelint styles/*.css
else
echo "No CSS files found to lint"
fi
7 changes: 7 additions & 0 deletions .htmlhintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"tagname-lowercase": true,
"attr-lowercase": true,
"alt-require": true,
"id-unique": true,
"tag-pair": true
}
10 changes: 10 additions & 0 deletions .stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": ["stylelint-config-standard"],
"rules": {
"declaration-block-no-duplicate-properties": true,
"no-duplicate-selectors": true,
"value-keyword-case": "lower",
"selector-type-case": "lower",
"block-no-empty": true
}
}
18 changes: 18 additions & 0 deletions src/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>my portfolio</title>
<link rel="stylesheet" href="../styles/home.css">
</head>
<body>
<header>
<h1>welcome to my portfolio</h1>
</header>

<main>
<p>this is my portfolio website</p>
<img src="placeholder.jpg" alt="placeholder image">
</main>
</body>
</html>
17 changes: 17 additions & 0 deletions styles/home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
body {
font-family: arial, sans-serif;
margin: 0;
padding: 0;
background-color: #f5f5f5;
}

header {
background-color: #333;
color: white;
padding: 1rem;
}

h1 {
color: #333;
font-size: 2rem;
}