[FIX] slug method should return string instead of symbol to allow Mod…#6
Merged
khasinski merged 1 commit intokhasinski:mainfrom Mar 26, 2026
Merged
[FIX] slug method should return string instead of symbol to allow Mod…#6khasinski merged 1 commit intokhasinski:mainfrom
khasinski merged 1 commit intokhasinski:mainfrom
Conversation
noelblaschke
force-pushed
the
main
branch
2 times, most recently
from
bdde316 to
387a286
Compare
Contributor
Author
|
Fixed linting issues and updated spec |
Owner
|
Thanks @noelblaschke, good catch! Merged. EDIT: Released in 0.5.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for your work!
RubyLLM's Model.refresh! will throw
because of RubyLLMs sorting mechanism in:
https://github.com/crmne/ruby_llm/blob/3c6e53c36e8eef44e4a48583c68d34ba3675043a/lib/ruby_llm/models.rb#L236
This will fail trying to compare a string provider (e.g. "open_ai") with a symbol provider (e.g. :openai_responses)