Skip to content

Conversation

@dkdltm221
Copy link
Contributor

@dkdltm221 dkdltm221 commented Jan 23, 2026

Summary

해당 PR에 대한 요약을 작성해주세요.

기존에 이름을 정할때 논문 -> 보고서로 작성하기로 정했기 때문에 이를 반영하고자합니다.
SubmissionType 표시용 라벨 변경하였습니다.

Tasks

  • 중간논문 -> 중간보고서로 네이밍 변경

To Reviewer

(없을 경우 삭제) 더 전달할 내용이 있다면 여기에 작성해주세요.

Screenshot

(없을 경우 삭제) 작업한 내용에 대한 스크린샷을 첨부해주세요.

@dkdltm221 dkdltm221 self-assigned this Jan 23, 2026
@dkdltm221 dkdltm221 added the 🔨refactor refactoring code label Jan 23, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

SubmissionType 열거형 상수의 라벨을 변경합니다. MIDTHESIS와 FINALTHESIS의 라벨이 각각 "중간논문"에서 "중간보고서"로, "최종논문"에서 "최종보고서"로 업데이트되었습니다. 열거형 구조나 동작 로직에는 변화가 없습니다.

Changes

집단 / 파일 변경 요약
열거형 라벨 변경
aics-domain/src/main/java/kgu/developers/domain/schedule/domain/SubmissionType.java
MIDTHESIS와 FINALTHESIS의 라벨을 "중간논문" → "중간보고서", "최종논문" → "최종보고서"로 변경

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • LeeHanEum
  • JangYeongHu
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경 사항의 주요 내용을 명확하게 요약하고 있습니다. SubmissionType의 표시용 라벨 수정이라는 핵심 변경 사항을 정확하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR 설명이 변경 사항과 관련이 있으며, SubmissionType 라벨 변경의 목적을 명확히 서술하고 있습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Test Coverage Report

Overall Project 80.75% -0.19% 🍏
Files changed 77.78% 🍏

Module Coverage
aics-domain 75.66% -0.29% 🍏
Files
Module File Coverage
aics-domain SubmissionType.java 100% 🍏
GraduationType.java 100% 🍏
GraduationUserQueryService.java 24.59% -3.28%

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #321   +/-   ##
==========================================
  Coverage      87.25%   87.25%           
  Complexity        67       67           
==========================================
  Files             24       24           
  Lines            259      259           
  Branches          14       14           
==========================================
  Hits             226      226           
  Misses            21       21           
  Partials          12       12           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6997afd...f00424a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkdltm221 dkdltm221 requested review from 2heunxun and hoTan35 January 23, 2026 06:37
Copy link
Contributor

@JangYeongHu JangYeongHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

추가적인 부탁이긴 하나 혹시 이 PR에서 코드 내의 중간 논문/ 최종 논문 은 모두 중간 / 최종 보고서로, GraduationType보고서논문으로 변경하는 일까지 담당할 수 있을까요?

졸업 논문, 중간 보고서, 최종 보고서로 코드 내의 네이밍을 일관성 있게 통일시켜야 할 것 같아서요

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Caution

Docstrings generation - FAILED

No docstrings were generated.

@JangYeongHu
Copy link
Contributor

JangYeongHu commented Jan 23, 2026

잘 수정해 주신 것 같네요. 수고하셨습니다.

@dkdltm221 dkdltm221 merged commit 3e966da into develop Jan 23, 2026
5 checks passed
@dkdltm221 dkdltm221 deleted the refactor/KD-66 branch January 23, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨refactor refactoring code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants