-
Notifications
You must be signed in to change notification settings - Fork 1
refactor/KD-66 : SubmissionType 표시용 라벨 수정 #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughSubmissionType 열거형 상수의 라벨을 변경합니다. MIDTHESIS와 FINALTHESIS의 라벨이 각각 "중간논문"에서 "중간보고서"로, "최종논문"에서 "최종보고서"로 업데이트되었습니다. 열거형 구조나 동작 로직에는 변화가 없습니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage Report
Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #321 +/- ##
==========================================
Coverage 87.25% 87.25%
Complexity 67 67
==========================================
Files 24 24
Lines 259 259
Branches 14 14
==========================================
Hits 226 226
Misses 21 21
Partials 12 12 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
JangYeongHu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
추가적인 부탁이긴 하나 혹시 이 PR에서 코드 내의 중간 논문/ 최종 논문 은 모두 중간 / 최종 보고서로, GraduationType의 보고서는 논문으로 변경하는 일까지 담당할 수 있을까요?
졸업 논문, 중간 보고서, 최종 보고서로 코드 내의 네이밍을 일관성 있게 통일시켜야 할 것 같아서요
|
Caution Docstrings generation - FAILED No docstrings were generated. |
|
잘 수정해 주신 것 같네요. 수고하셨습니다. |
Summary
해당 PR에 대한 요약을 작성해주세요.
기존에 이름을 정할때 논문 -> 보고서로 작성하기로 정했기 때문에 이를 반영하고자합니다.
SubmissionType 표시용 라벨 변경하였습니다.
Tasks
To Reviewer
(없을 경우 삭제) 더 전달할 내용이 있다면 여기에 작성해주세요.
Screenshot
(없을 경우 삭제) 작업한 내용에 대한 스크린샷을 첨부해주세요.