MCDM Class Bundle first pass #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgar
requested changes
Sep 18, 2025
src/sheets/quadrone/actor/character-parts/favorites/FavoriteItemGeneric.svelte
Outdated
Show resolved
Hide resolved
src/sheets/quadrone/actor/character-parts/favorites/FavoriteItemGeneric.svelte
Outdated
Show resolved
Hide resolved
| const sheetPreferences = SheetPreferencesService.getByType(context.actor.type); | ||
| const sortMode = sheetPreferences.tabs?.[tabId]?.sort ?? 'm'; | ||
| const sectionConfig = TidyFlags.sectionConfig.get(context.actor)?.[tabId]; | ||
| const allSections: PowersSection[] = [...Object.entries(orderToPowersMap).map(([order, powers]) => ({ |
There was a problem hiding this comment.
There is no reason to spread here. .map creates a new array and so does Object.entries
There was a problem hiding this comment.
Yep, good call. I'm combining two arrays here, and originally did a .concat, but typing disagreed because I hadn't specified the first map's type explicitly. Fixed now.
There was a problem hiding this comment.
Oh, I didn't realise you were concatenating. In which case, what you had before would have been fine. Both .concat and spreading will create another array, the only way to avoid it would be by .pushing the second array into the first but that just makes it more complicated.
kgar
approved these changes
Sep 18, 2025
|
I'll await any additional thoughts from Naito. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things added/changed:
FavoriteItemGenerichad a minor glow-up (same "save" treatment as favorited spells)