UI overhaul i feel the rush #1383

kgar · 2025-09-11T14:32:50Z

In addition to overhaul work:

Addresses Move "Prototype Token" and "Token" header menu options onto the header, out of the menu #1390
Moved "Restore Transformation" out of the header menu, onto the header

Fixed encounter member column runtime reference to columns. Added resize observation to encounter members tab. Fixed CR column. Fixed Quantity column.

…caching context services are missing.

…, instead of item-specific ones.

…acker and build atop it.

- [x] Row 1 - [x] Creature Type Count row - [x] Row 2 - [x] Members count (assuming member quantities sum) - [x] XP - [x] GP summary - [x] Encounter header layout change - [x] Left: name, subtitles, button bar - [x] Right: difficulty badge

…lti-actor base class to share.

Set up encounter sidebar with Languages, Speeds, Senses, Skills, and Specials. Pulled back more content to share between multi-actor sheets. Removed draggability and context menu options from GroupSkillsCard.

Extend some group member tab styles to the combat tab. Removed rogue divider dot on encounter member name subtitle. Added members table to combat tab.

…and members tabs. Created encounter member toggle row action. Set up row actions for combat tab. Created ActivityActionsColumnHeader for adding activities. Corrected tooltip for the item create button.

…for Encounter members who are editable.

Added Quantity Formula column to Encounter Members table.

Encounter sheet style updates

…-tidy5e-sheet-2 into ui-overhaul-i-feel-the-rush

…make that the flag. Likewise, put all combat settings into a combat prop on the Member and Placeholder contexts. - [x] Refactor: ensure all encounter combat data flag updates also trim away nonexistent members/placeholders every time there's an update.

Removed unused code.

…/foundry-vtt-tidy-5e-sheets into feel-the-rush-2

laquasicinque · 2025-09-20T22:35:03Z

src/foundry/config.types.ts

      cubicFoot: VolumeUnitConfig;
      liter: VolumeUnitConfig;
    } & Record<string, VolumeUnitConfig>;
+    ENCOUNTER_DIFFICULTY: [number, number, number][];


Nitpick: I realise this comes from the dnd5e module, but I kinda dislike unlabeled tuples.

Suggested change

ENCOUNTER_DIFFICULTY: [number, number, number][];

ENCOUNTER_DIFFICULTY: [low: number, medium: number, high: number][];

would be a slight improvement just for the sake of readibility

laquasicinque · 2025-09-22T00:55:04Z

src/sheets/quadrone/actor/tabs/NpcBiographyTab.svelte

+                  document={context.actor}
+                  field={bioField.field}
+                  value={bioField.value}
+                  selectOnFocus={true}


Opinion: I believe you could just say selectOnFocus without explicitly saying it's true. It would match regular html as well (e.g <input disabled required>

laquasicinque · 2025-09-22T00:55:58Z

src/sheets/quadrone/actor/tabs/NpcBiographyTab.svelte

+      </div>
+      <ul class="biography-entries">
+        {#each bioFields as bioField (bioField.field)}
+          {#if bioField.value != null && bioField.value !== '' || context.unlocked}


Do you care (and is it possible) for the value to just be whitespace? i.e do you need to ?.trim()?

I didn't put trim since you can also have empty tags like <h1></h1> that you'd also have to look for and trim in that case.

Hmmm. potentially possible with a utility function I guess 😅 apply innerHTML and read textContent

laquasicinque · 2025-09-22T00:57:06Z

src/sheets/quadrone/actor/tabs/NpcBiographyTab.svelte

+  {#if (context.enriched.appearance !== '' &&
+        context.enriched.trait !== '' &&
+        context.enriched.ideal !== '' &&
+        context.enriched.bond !== '' &&
+        context.enriched.flaw !== ''


Thought: Not sure if this would work out better as an array with a .every

…t when creating a new placeholder.

…set placeholders (still working on images).

…ized.

…-vtt-tidy-5e-sheets into ui-overhaul-i-feel-the-rush

…cells. Fix for text alignment in Character sheet tables.

…/foundry-vtt-tidy-5e-sheets into feel-the-rush-2

Implemented image preview and filepicker image selection on Encounter Combat tab placeholders.

Implemented difficulty target swapping which applies to all encounter sheets from the user's perspective.

… all. Added style block for combat difficulty target select.

kgar and others added 30 commits September 11, 2025 09:29

Removed unnecessary warning log.

2e3a7b0

Fixed error with pinned filters.

08b978d

Fixed encounter member column runtime reference to columns. Added resize observation to encounter members tab. Fixed CR column. Fixed Quantity column.

Created generic InlineQuantityTracker for use beyond just items.

0e1994a

Updated TidyItemTableRow to tolerate when item expansion / item data …

7326159

…caching context services are missing.

Added SheetExpandedItemsCacheable handling to Container sheet.

ee09a8e

Implemented member quantity update handling.

76b2f81

Updated inline tracker css to target more generalized tracker classes…

85989ec

…, instead of item-specific ones.

Wired up quantity tracker for encounter member quantity column.

32ddc8e

Ensured a happy path member quantity update is a non-nullish value.

00e61d0

Set up min handling for inline quantity tracker.

feee0b8

Converted inline item quantity tracker to reuse the generic inline tr…

75fd1b4

…acker and build atop it.

Added drift correction to generic quantity tracker.

01ee092

Added Combat tab for Encounters.

d531028

Corrected loc key.

5975f51

- [x] Encounter subtitle

a5c2392

- [x] Row 1 - [x] Creature Type Count row - [x] Row 2 - [x] Members count (assuming member quantities sum) - [x] XP - [x] GP summary - [x] Encounter header layout change - [x] Left: name, subtitles, button bar - [x] Right: difficulty badge

Stubbed encounter skills and encounter members tab sidebar.

8fc7f34

Scaffolded member traits prep. Pulled back group trait prep to the mu…

e12e15e

…lti-actor base class to share.

Added member emphasis to Encounter Sheet.

e9c613d

Set up encounter sidebar with Languages, Speeds, Senses, Skills, and Specials. Pulled back more content to share between multi-actor sheets. Removed draggability and context menu options from GroupSkillsCard.

Renamed class groups-tab-content to group-tab-content.

8d5b232

Extend some group member tab styles to the combat tab. Removed rogue divider dot on encounter member name subtitle. Added members table to combat tab.

Stubbed the create button for encounter members table. Put in combat …

48e20a9

…and members tabs. Created encounter member toggle row action. Set up row actions for combat tab. Created ActivityActionsColumnHeader for adding activities. Corrected tooltip for the item create button.

Marked off done work

47c872c

Implemented compendium browser member adding.

be2793f

Added HP rollFormula button to group member HP column that will show …

f100231

…for Encounter members who are editable.

- [x] Members context menu for Encounter sheet

7df4ab7

Added Quantity Formula column to Encounter Members table.

7a5683a

- [X] Make Formula column a lower-priority, always-shown column

76be42c

2731bd4

Styling for the Encounter sheet header, columns, subtitle, and XP bar

46ed79e

Tried to scaffold out combat tab, more cleanup and style updates.

f791856

Merge pull request #1384 from jeffwain/close-encounters-of-the-5e-kind

bd61116

Encounter sheet style updates

kgar and others added 7 commits September 21, 2025 14:15

Merge branch 'ui-overhaul-i-feel-the-rush' of github.com:kgar/foundry…

02d1b35

…-tidy5e-sheet-2 into ui-overhaul-i-feel-the-rush

Rearranged character subtitles to show additional classses by default.

2a27d76

Added adapter for managing combatant settings.

a3048e2

Fixed inappropriate identifier management in row action components.

824cb9a

Removed unused code.

Merge branch 'ui-overhaul-i-feel-the-rush' of https://github.com/kgar…

8b961ba

…/foundry-vtt-tidy-5e-sheets into feel-the-rush-2

Tweaks to actor sheets table styles

0da078b

laquasicinque reviewed Sep 22, 2025

View reviewed changes

kgar and others added 22 commits September 22, 2025 22:07

Fixed issues with using CombatantSettings.

3ed6291

Added optional partial data and combatant settings that one can submi…

4284c78

…t when creating a new placeholder.

Corrected localization on encounter delete button.

fca8fba

Added context menu for combat placeholders.

be7adc4

Fixed individual roll initiative button.

66bf3d7

Moved "Restore Transformation" header control to header.

9034434

Encounter sheet styling for combat tab. Added sidebar buttons for pre…

5e29869

…set placeholders (still working on images).

Misc css fixes. NPC sidebar class name change, biography layout final…

c730338

…ized.

Moved prototype token / token settings to the header.

5b9f1e1

Merge branch 'ui-overhaul-i-feel-the-rush' of github.com:kgar/foundry…

4da29c2

…-vtt-tidy-5e-sheets into ui-overhaul-i-feel-the-rush

Styling updates for tab item counts and encounter inventory quantity …

50c09b0

…cells. Fix for text alignment in Character sheet tables.

Merge branch 'ui-overhaul-i-feel-the-rush' of https://github.com/kgar…

677b499

…/foundry-vtt-tidy-5e-sheets into feel-the-rush-2

Fix for crazy long tooltips

68c9c67

Resolved dep warnings for ImagePopout.

3a1da95

Implemented image preview and filepicker image selection on Encounter Combat tab placeholders.

Removed rogue divider dot.

ed4622e

5f741a7

Updated enc sidebar to appropriate icons

3286223

Added loc keys for difficulty target and primary party.

baf6194

Added encounter difficulty target group ID flag for game.user.

106e1fd

Implemented difficulty target swapping which applies to all encounter sheets from the user's perspective.

Adjusted styles for meter labels to maintain a normal line height for…

f33357d

… all. Added style block for combat difficulty target select.

Removed max value on XP budget bar. It confuses more than helps.

855dc1e

Difficulty is guaranteed, label is not. Updated accordingly.

a5e4651

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UI overhaul i feel the rush #1383

UI overhaul i feel the rush #1383

Uh oh!

kgar commented Sep 11, 2025 •

edited

Loading

Uh oh!

laquasicinque Sep 20, 2025

Uh oh!

laquasicinque Sep 22, 2025 •

edited

Loading

Uh oh!

laquasicinque Sep 22, 2025

Uh oh!

jeffwain Sep 22, 2025 •

edited

Loading

Uh oh!

laquasicinque Sep 22, 2025

Uh oh!

laquasicinque Sep 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

	ENCOUNTER_DIFFICULTY: [number, number, number][];
	ENCOUNTER_DIFFICULTY: [low: number, medium: number, high: number][];

UI overhaul i feel the rush #1383

Are you sure you want to change the base?

UI overhaul i feel the rush #1383

Uh oh!

Conversation

kgar commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laquasicinque Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

laquasicinque Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laquasicinque Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

jeffwain Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laquasicinque Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

laquasicinque Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kgar commented Sep 11, 2025 •

edited

Loading

laquasicinque Sep 22, 2025 •

edited

Loading

jeffwain Sep 22, 2025 •

edited

Loading

laquasicinque Sep 22, 2025 •

edited

Loading