chore: linkinator#193
Merged
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
Based-on: keymanapp/keyman.com#788 Test-bot: skip
mcdurdin
force-pushed
the
chore/linkinator
branch
from
13b5f83 to
c7641cd
Compare
ermshiperete
approved these changes
Jun 16, 2026
|
|
||
| # | ||
| # Finally, run the tests; note that this is almost all replicated in build.sh; here logging is reduced (TODO sync) | ||
| # Run tests -- these step definitions are NEARLY identical across: |
Contributor
There was a problem hiding this comment.
I didn't compare what the differences are between the versions in the different repos, but if it's only things like paths then it might be worth considering creating a custom action in shared-sites that we then could call/use from here.
Would then become something like:
- uses: keymanapp/shared-sites/github-actions/php-unit-test-action@master
Member
Author
There was a problem hiding this comment.
Agree. There's a bit of friction because of some differences, particularly with s.keyman.com and website-local-proxy. I have this down for v20 for keymanapp/keyman.com#795.
chore: verify bootstrap version format before merge
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based-on: keymanapp/keyman.com#788
Test-bot: skip