refactor(web): define common buildCorrectionSequence method used for all model types 🔪#16028
Draft
jahorton wants to merge 4 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
Bot
added
web/
web/predictive-text/
and removed
epic-boundary-correction
labels
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/abstract-whitespace-tokenization-mapping
branch
from
6374711 to
9c13347
Compare
jahorton
force-pushed
the
refactor/web/correction-sequence-construction
branch
from
581115f to
bc3691e
Compare
Build-bot: skip build:web Test-bot: skip
To better handle inputs that shift the word-boundary in some custom models and models released before Keyman 14.0, this PR provides generalized re-use of the whitespace-based token-transition algorithm used for our most prominently-supported models. Build-bot: skip build:web Test-bot: skip
…all model types Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/correction-sequence-construction
branch
from
bc3691e to
b6ba677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip