epic: boundary-correction 🔪#16025
Draft
mcdurdin wants to merge 37 commits into
Draft
Conversation
Per the search quotient graph documentation, we should no longer have one node type handle all edit operation types. Our current ("legacy") implementation and unit tests are most tailored for the needs of 'substitution' edit types, so this PR starts there.
Build-bot: skip build:web
Test-bot: skip
… tests to use new spur type
…-legacy splits, merges
Build-bot: skip build:web Test-bot: skip
…ion-edit search-graph edges Build-bot: skip build:web Test-bot: skip
…d spur types Build-bot: skip build:web Test-bot: skip
… tests I happened to discover that the predictive-text "helper" fixtures' unit tests were not actually being run. This links them in (during /worker-thread builds) to ensure they get run too. Build-bot: skip build:web Test-bot: skip
Build-bot: skip build:web Test-bot: skip
…o corrections could be found Build-bot: skip build:web Test-bot: skip
…eat/web/insertion-spurs
…nd-fix-pred-text-helpers
…est-quotient-specialized-splits
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Relates-to: #12893 Test-bot: skip
…y-correction chore: establish epic/boundary-correction 🔪
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
…-predictable-unless-needed
…(to be restored in followup PR)" This reverts commit da12b14.
feat(web): implement dedicated substitution-spur class, tests 🚂 🔪
…table-unless-needed fix(web): block use of predictable "fallback" result to cases where no corrections could be found 🚂 🔪
feat(web): add dedicated quotient-spur type for insertion edits 🚂
feat(web): add dedicated DeletionQuotientSpur type for handling deletion-edit search-graph edges 🚂
…elpers feat(web): extend search-graph test-helper funcs to handle specialized spur types 🚂
…xt-helpers fix(web): link and patch up predictive-text test helper function unit tests 🚂
…alized-splits feat(web): add test for split operations on quotient-graph doc example 🚂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip