Fix missing symlinks on MacOS #27603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisnojima can you review this PR? The workaround isn't very easy to find (the linked GH issue) and not having this makes the CLI unusable on a MacOS install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to an old issue: #3627 that is still present today
When installing the Keybase client, it attempts to symlink
keybaseandgit-remote-keybaseto/usr/local/bin. On MacOS this directory is write-protected and the operation fails.This PR attempts to make a change so that the installer will try to run sudo using
sh -c ...if the directory is not writeable by us.