-
Notifications
You must be signed in to change notification settings - Fork 73
Fiber DRC segmentation and SD action update for downstream digitization and reconstruction #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6dfc734
to
58fb9ce
Compare
58fb9ce
to
6304546
Compare
1f7d6bb
to
b896bd2
Compare
Hi @BrieucF Could you do a final review please? |
dd4hep::Position localPos = dd4hep::Position(0., 0., 0.); | ||
|
||
// get local coordinate | ||
if (IsSiPM(cID)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this if
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from a historical reason - this function was designed to return the position of the tower (precisely "wafer" behind the tower) rather than the individual hit position when IsSiPM
returns 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you add this as an inline comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've just done it now
… xml file 2) add function to calculate the rear end position of the fiber
…lume of the scintillation fibers
b896bd2
to
995d40a
Compare
To ease the review process, please consider the following before opening a pull request:
--ff-only
) tok4geo/main
BEGINRELEASENOTES
ENDRELEASENOTES
GridDRcalo_k4geo
. It is needed (and only needed) for the digitizer of the DRC that estimates the pulse timing based on the distance between thestep
and the readout.