Skip to content

Emulating detector efficiency in DDPlanarDigi #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mahmoudali2
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

@jmcarcell
Copy link
Member

As discussed in person, here I thought it would be better to have an algorithm to simulate efficiency for any collection, instead of having to add it to each algorithm individually. So I will close this PR in favor of a generic approach to simulating efficiency.

Then @mahmoudali2 noted that because not all the hits are preserved in DDPlanarDigi, the efficiency can not be exactly (even with the changes in this PR) what is configured. There are two options to control this: MaxTries; the bigger, the more likely the hit is to be kept, and ForceHitsOntoSurface, which if set to false (default) will remove every hit for which the surf->insideBounds check from DD4hep fails. So in theory, by setting ForceHitsOntoSurface to true and MaxTries big enough, it should be possible to keep all the hits, which would allow for a previous efficiency cut to be exact.

@jmcarcell
Copy link
Member

Closing in favor of key4hep/k4FWCore#322 to emulate efficiencies.

@jmcarcell jmcarcell closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants