files deduplication

[doomedraven]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @doomedraven, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances file management by implementing a robust deduplication strategy. It centralizes the storage of various analysis artifacts, such as extracted and dropped files, into a single repository. This approach leverages symlinks to avoid duplicate data, thereby conserving disk space. Furthermore, it introduces a new, configurable cleanup utility to automatically prune old and unreferenced files from this central storage, ensuring efficient resource utilization and system hygiene.

Highlights

• Centralized File Storage: Extracted, dropped, and other analysis-related files are now stored centrally in storage/files based on their SHA256 hash, preventing redundant copies across multiple analyses.
• Symlinking for Deduplication: Analysis folders will now contain symlinks (or copies as a fallback) pointing to these centrally stored files, optimizing disk space usage.
• New File Cleanup Utility: A new function, files_clean_before, has been introduced to automatically remove unreferenced files from the central storage/files directory that are older than a specified time range.
• Configurable Cleanup: The new file cleanup mechanism can be configured via the config.cleaner.files option, allowing administrators to define the retention policy for unreferenced files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a file deduplication mechanism to save disk space by centralizing stored files and using symlinks. A corresponding cleaner utility is also added to manage the central storage. The overall approach is sound and the implementation is consistent across the modified files. I have identified a couple of areas for improvement to enhance the robustness of the new functionality. My comments include a fix for a potential bug in the new cleaner and a suggestion to make the symlinking logic more robust and consistent.