Skip to content

tests(*): attempt for flaky tests #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

tests(*): attempt for flaky tests #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/test/java/io/kestra/plugin/fs/sftp/ListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
import jakarta.inject.Named;
import org.junit.jupiter.api.Test;

import java.util.ArrayList;
import java.util.Map;
import java.util.concurrent.CopyOnWriteArrayList;

import static io.kestra.plugin.fs.sftp.SftpUtils.PASSWORD;
import static io.kestra.plugin.fs.sftp.SftpUtils.USERNAME;
Expand All @@ -35,7 +35,7 @@ class ListTest {

@Test
void all() throws Exception {
java.util.List<LogEntry> logs = new ArrayList<>();
java.util.List<LogEntry> logs = new CopyOnWriteArrayList<>();
var receive = TestsUtils.receive(logQueue, l -> logs.add(l.getLeft()));
String expectedEnabledRsaSha1Logs = "RSA/SHA1 is enabled, be advised that SHA1 is no longer considered secure by the general cryptographic community.";

Expand Down Expand Up @@ -76,6 +76,6 @@ void all() throws Exception {

TestsUtils.awaitLog(logs, log -> log.getMessage() != null && log.getMessage().contains(expectedEnabledRsaSha1Logs));
receive.blockLast();
assertThat(logs.stream().anyMatch(log -> log.getMessage() != null && log.getMessage().contains(expectedEnabledRsaSha1Logs)), is(true));
assertThat(java.util.List.copyOf(logs).stream().anyMatch(log -> log.getMessage() != null && log.getMessage().contains(expectedEnabledRsaSha1Logs)), is(true));
}
}
Loading