test: Add new sanity check test #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
test-sanity
branch
5 times, most recently
from
e059409 to
e250a65
Compare
|
What do you think @wkz i think this is the best aproach, to add the version in output/images since this will allow us to maybe not have a squashfs image? Or am i overthinking. And when running tests, we does not use the squash image as default, we use qcow2 so we need read it out before we start the testsystem anyway. |
wkz
requested changes
Sep 4, 2025
You need first to clone gns3-registry from https://github.com/GNS3/gns3-registry Follow this steps: 1. ./utils/bump-gns3.py 25.08.0 ../../gns3/gns3-registry/appliances/infix.gns3a 2. TEST in gns3, just add the new version, start it. 3. run python3 check.py inside gns3-registry, verify infix is ok. 4. Create a pull request to gns3-registry This fix #1107
mattiaswal
force-pushed
the
test-sanity
branch
from
1e322a7 to
422a753
Compare
wkz
approved these changes
Sep 5, 2025
test/env
Outdated
| @@ -154,7 +153,7 @@ containerize=yes | |||
| files= | |||
| basedir="$ixdir" | |||
|
|
|||
| while getopts "b:cCDf:hiKp:q:rt:" opt; do | |||
| while getopts "b:cCDf:hiKp:q:rt:v:" opt; do | |||
There was a problem hiding this comment.
Suggested change
| while getopts "b:cCDf:hiKp:q:rt:v:" opt; do | |
| while getopts "b:cCDf:hiKp:q:rt:" opt; do |
Not used anymore. Maybe you could also get rid of the whitespace change above.
One to verify it is the correct version on the duts and one that check that it is the correct bootorder.
mattiaswal
force-pushed
the
test-sanity
branch
from
422a753 to
dce9a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests if the correct boot partition and version is used.
Also add a script to add new releases to existing gns3 marketplace appliance, this fix #1107
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: