Skip to content

Test fixes #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 15, 2025
Merged

Test fixes #1135

merged 14 commits into from
Sep 15, 2025

Conversation

troglobit
Copy link
Contributor

@troglobit troglobit commented Sep 2, 2025 •
edited
Loading

Description

Major refactor of two tests disabled in v25.08:

Also included is an update to the test report (PDF)

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@troglobit troglobit added the ci:main Build default defconfig, not minimal label Sep 2, 2025
@troglobit troglobit force-pushed the test-fixes branch 3 times, most recently from 9325132 to 6cfb512 Compare September 7, 2025 12:38
@troglobit troglobit mentioned this pull request Sep 7, 2025
Closed
@troglobit troglobit force-pushed the test-fixes branch 4 times, most recently from 6efb18d to be7fba5 Compare September 7, 2025 21:00
@troglobit troglobit marked this pull request as ready for review September 7, 2025 21:01
@Copilot Copilot AI review requested due to automatic review settings September 7, 2025 21:01
Copilot

This comment was marked as off-topic.

Sign in to view

mattiaswal
mattiaswal approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@mattiaswal mattiaswal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Gave a suggestion for even more cleanup 🧹

wkz
wkz requested changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly took a look at the tests, did not quite have the energy to review the report stuff but I trust it is awesome as always 😄

@troglobit
board/common: ensure efi-part.vfat is saved in build tree
c1ad807 
Fixes #1132

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/infamy: refactor Furl class to support list of needles
52beeb5 
Also, add some documentation to lower barrier of entry/use.

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/case/infix_container: refactor container-environment
1aad255 
Refactor test to use httpd container instead and return ENV with a CGI.

Fixes #1131

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/case/infix_services: refactor mdns-allow-deny
b657183 
Major refactor to redesign how listeners and traffic is started in parallel.

Fixes #1130

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/spec: pep-8 fixes, minor cleanup only
87f9b58 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/infamy: silence schema download in restconf backend
9fe661f 
NETCONF backedn already silenced.

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test: relocate logic for creating test-report.pdf from workflow
c14140a 
It should be possible to create test reports manually, so logically
the GitHub workflow should call a make rule in test.mk

Untested: branding, or any case where Infix is used as a BR2_EXTERNAL

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/case: simplify AsciiDoc image references
fe2d0f4 
This commit greatly simplifies AsciiDoc image references in generated
Readme.adoc files.  The two focused use-cases that remain after this
change are working references in:

 - Generated output/images/test-report.pdf
 - Viewing test's Readme.adoc from GitHub

Previously we aimed to have working images also when the test's Readme
was included in the parent directory's Readme.adoc.  This, however, is
not supported as of this commit.  It seems unlikely also to ever be a
supported feature of AsciiDoc on GitHub, for details, see the following
issue: <github/markup#1095>

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit mentioned this pull request Sep 15, 2025
Open
@troglobit troglobit requested a review from wkz September 15, 2025 06:04
wkz
wkz approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪

@troglobit
test/spec: refactor test spec & report generation
b4a5b35 
Import new 9pm version for improved test report generation.  With this
in place we can take the opportunity to also refactor and simplify the
test spec. generation.

Fixes #1129

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test: add intro blurb to each subsystem
249af70 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/case/infix_dhcp: allow generating subsystem test resports
2171fd1 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/case: rename foo.adoc -> test.adoc and update all Readme.adoc
eb3e64d 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test/case: use 9pm 'name:' for all test names
44d3780 
To reduce the duplication of effort between 9pm and the Infamy framework
this change consolidates the move from local 'infamy: title:' extension
to 9pm 'name:'.

For the parameterized tunnel tests we leverage the 9pm dynamic test-spec
variable, which looks for a correspodning <case>.adoc instead of static
Readme.adoc, when generating the test report.

Each test documentation should cover all aspects of the test, much like
the usage text of a UNIX program.  To this end, the tunnel test docs are
now more spelled out, including all invariants.

Some refactoring of these tests were also necessary, e.g., replacing any
reserved Python keywords like 'type', and other PEP-8 fixes.

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
test: consistent naming for all yaml files
142e4e9 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit merged commit 1989eff into main Sep 15, 2025
6 checks passed
@troglobit troglobit deleted the test-fixes branch September 15, 2025 14:21
@troglobit troglobit added this to the Infix v25.09 milestone Sep 16, 2025
@jovatn jovatn added the cn:styx label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiaswal mattiaswal mattiaswal approved these changes

Copilot code review Copilot Copilot left review comments

@wkz wkz wkz approved these changes

@rical rical Awaiting requested review from rical

Assignees
No one assigned
Labels
ci:main Build default defconfig, not minimal cn:styx
Projects
None yet
Milestone
Infix v25.09
Development

Successfully merging this pull request may close these issues.
4 participants
@troglobit @wkz @mattiaswal @jovatn