Hide hardware information in build log viewer drawer #1284
Conversation
There was a problem hiding this comment.
Hello! Thanks for your contribution.
Your change to remove the info from the log viewer seems correct to me (@MarceloRobert will check it in detail).
However we have to clean up this PR a bit. You add the package-lock.json and routetree.gen.ts files in, but they seem unrelated to the change we need to fix the issue.
Thanks again for your patch!!
dashboard/src/routeTree.gen.ts
Outdated
There was a problem hiding this comment.
No need to change routeTree gen. Make sure you have the updated libraries by running pnpm install in the frontend directory since this is an automatically generated file.
There was a problem hiding this comment.
The change seems to be ok, but when there is no log to be shown the "No logs available" is getting right after the commit hash. You can change the span component above to a div and they will be in the correct position, try to keep the bottom margin as well, it's helpful to separate the information.
|
I believe that the CI will fail but don't worry about it, we are still going to improve the way that GitHub handles forks (issue #1181) |
| @@ -95,21 +95,23 @@ export const LogViewerCard = ({ | |||
| ) : ( | |||
| <> | |||
| <div> | |||
| <span className="font-medium"> | |||
| <div className="font-medium mb-2"> | |||
There was a problem hiding this comment.
In the way that you made it now, there is a double margin on log viewers with the hardware text. Check the placement of the components, try to keep the styling similar with or without the hardware text.
There was a problem hiding this comment.
@MarceloRobert , I will make required changes
|
Also, sorry if my last comment was confusing but please do remove the poetry-lock and routeTree changes |
|
This PR will be closed for being stale. The issue will be continued on PR #1313 |
What does this PR do?
->Hides hardware information in the log viewer for build logs.
->Keeps hardware information visible for test logs.
->Cleans up the UI by removing unnecessary details for builds.
How was this done?
->Updated LogViewerCard to only show hardware info when the log type is not 'build'.
Closes #1283