Feat: filter tree details origin #1276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double underlines should represent getting data from another table, test_origin is just a rename of origin so it should only have one underline
Adds origin filtering capability per tab, using the diffFilter structure Part of #1251
MarceloRobert
force-pushed
the
feat/filter-tree-details-origin
branch
from
66882ae to
dbaabc4
Compare
MarceloRobert
changed the title
giubrocchi
reviewed
Jun 9, 2025
| @@ -165,6 +166,11 @@ const BootsTab = ({ treeDetailsLazyLoaded }: BootsTabProps): JSX.Element => { | |||
| } | |||
| }, [isEmptySummary, summaryBootsData]); | |||
|
|
|||
| const showOriginCard = useMemo( | |||
There was a problem hiding this comment.
This is being used in other components and has the same logic, can this be moved to an utils file (or a hook to use the memo) to share this logic?
There was a problem hiding this comment.
I think I could, but now that I look at it again, I think I can even move it to the MemoizedOriginsCard component itself
giubrocchi
reviewed
Jun 9, 2025
| @@ -209,6 +215,13 @@ const BootsTab = ({ treeDetailsLazyLoaded }: BootsTabProps): JSX.Element => { | |||
| environmentCompatible={hardwareData} | |||
| diffFilter={diffFilter} | |||
| /> | |||
| {showOriginCard && summaryBootsData && ( | |||
There was a problem hiding this comment.
Doesn't showOriginCard already checks for falsy values for summaryBootsData?
There was a problem hiding this comment.
Yes but typescript can't guarantee that summaryBootsData wasn't reassigned to undefined, so it shows an error in summaryBootsData.origins in the lines below if I don't use && summaryBootsData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree details page can have tests or builds from different origins than the checkout, so there should be a possibility to filter the origin of each tab in the tree details.
Changes
tests__origin->tests_origin)How to test
Closes #1251