Pass external callchain entry to get_perf_callchain #10493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: ec439c3 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7f3448b to
0de3956
Compare
Author
|
Upstream branch: ec439c3 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
21a1545 to
f20836a
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
0de3956 to
2d78e4d
Compare
Author
|
Upstream branch: 3d60306 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
f20836a to
9f87e04
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2d78e4d to
5007636
Compare
Author
|
Upstream branch: d2749ae |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
9f87e04 to
ed2f7a9
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5007636 to
0ac68c9
Compare
Author
|
Upstream branch: f785a31 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
ed2f7a9 to
5dcba88
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
0ac68c9 to
e8b906b
Compare
Author
|
Upstream branch: ac1c5bc |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
5dcba88 to
8da87cf
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e8b906b to
302988a
Compare
Author
|
Upstream branch: f14cdb1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
8da87cf to
f6755d9
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
302988a to
a14913f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a14913f to
d5a1b3c
Compare
Author
|
Upstream branch: 317a5df |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
ebec06e to
fae2a14
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
d5a1b3c to
cd2ddbb
Compare
Author
|
Upstream branch: ccaa6d2 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
fae2a14 to
5082d7b
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
cd2ddbb to
e461c3e
Compare
Author
|
Upstream branch: ccaa6d2 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
5082d7b to
8cb588f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e461c3e to
cbcc41d
Compare
From BPF stack map, we want to ensure that the callchain buffer will not be overwritten by other preemptive tasks. Peter suggested provide more flexible stack-sampling APIs, which can be used in BPF, and we can still use the perf callchain entry with the help of these APIs. The next patch will modify the BPF part. In the future, these APIs will also make it convenient for us to add stack-sampling kfuncs in the eBPF subsystem, just as Andrii and Alexei discussed earlier. Signed-off-by: Peter Zijlstra <[email protected]> Signed-off-by: Tao Chen <[email protected]>
Author
|
Upstream branch: ccaa6d2 |
As Alexei noted, get_perf_callchain() return values may be reused if a task is preempted after the BPF program enters migrate disable mode. The perf_callchain_entres has a small stack of entries, and we can reuse it as follows: 1. get the perf callchain entry 2. BPF use... 3. put the perf callchain entry And Peter suggested that get_recursion_context used with preemption disabled, so we should disable preemption at BPF side. Acked-by: Yonghong Song <[email protected]> Signed-off-by: Tao Chen <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
8cb588f to
5db860c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
13 times, most recently
from
e7b5368 to
1e194b1
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
2 times, most recently
from
76c54c7 to
1a6c4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Pass external callchain entry to get_perf_callchain
version: 7
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1034091