Support array presets in veristat #5486
Open
+414
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: cd7312a |
|
Upstream branch: cd7312a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
672ea96 to
fc3be1c
Compare
|
Upstream branch: cd7312a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
fc3be1c to
40f0b24
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
45c71f6 to
4516bd2
Compare
|
Upstream branch: e30329b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
40f0b24 to
7fac121
Compare
|
Upstream branch: e30329b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
7fac121 to
a97e0f1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4516bd2 to
983d136
Compare
|
Upstream branch: 99fe8af |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
a97e0f1 to
5225faf
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
983d136 to
097b64d
Compare
|
Upstream branch: c11f34e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
5225faf to
918991f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
097b64d to
1daac42
Compare
|
Upstream branch: 3ce7cdd |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
918991f to
6333f93
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1daac42 to
86c8a5d
Compare
|
Upstream branch: 3ce7cdd |
Refactor var preset parsing in veristat to simplify implementation. Prepare parsed variable beforehand so that parsing logic is separated from functionality of calculating offsets and searching fields. Introduce rvalue struct, storing either int or enum (string value), will be reused in the next patch, extract parsing rvalue into a separate function. Signed-off-by: Mykyta Yatsenko <[email protected]> Acked-by: Eduard Zingerman <[email protected]>
Implement support for presetting values for array elements in veristat. For example: ``` sudo ./veristat set_global_vars.bpf.o -G "arr[3] = 1" ``` Arrays of structures and structure of arrays work, but each individual scalar value has to be set separately: `foo[1].bar[2] = value`. Signed-off-by: Mykyta Yatsenko <[email protected]> Acked-by: Eduard Zingerman <[email protected]>
Modify existing veristat tests to verify that array presets are applied as expected. Introduce few negative tests as well to check that common error modes are handled. Signed-off-by: Mykyta Yatsenko <[email protected]> Acked-by: Eduard Zingerman <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/969034=>bpf-next
branch
from
6333f93 to
4de8e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Support array presets in veristat
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=973580