Fix refs not being extracted #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in reference offset calculation when searching for reference text within cleaned paragraphs. The issue was in the search area calculation where ref['offset_start'] was incorrectly used instead of ref['offset_end'] for the upper bound.
- Fixed incorrect search area boundary calculation for reference text matching
- Added a test to validate correct offset calculation for references in JSON conversion
- Removed a large test data file (bao.json) and added a smaller XML test file
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grobid_client/format/TEI2LossyJSON.py | Fixed bug where search_end used offset_start instead of offset_end |
| tests/test_conversions.py | Added test case to verify reference offset accuracy |
| tests/resources/refs_offsets/bao.json | Removed large test data file |
| tests/resources/refs_offsets/2021.naacl-main.224.grobid.tei.xml | Added new XML test file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #93