Skip to content

Fix compiler warnings #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nyetwurk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiler warnings #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ CFLAGS ?= -O2
all: $(BIN)

$(BIN):
$(CC) -o $(BIN) $(CFLAGS) -framework Foundation -framework ApplicationServices src/main.m
$(CC) -o $(BIN) $(CFLAGS) -framework Foundation -framework AppKit -framework ApplicationServices src/main.m

install: $(BIN)
install -d $(DESTDIR)$(BINDIR)
Expand Down
36 changes: 22 additions & 14 deletions src/main.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,43 @@
//

#import <Foundation/Foundation.h>
#import <AppKit/AppKit.h>
#import <ApplicationServices/ApplicationServices.h>

NSString* app_name_from_bundle_id(NSString *app_bundle_id) {
return [[[app_bundle_id componentsSeparatedByString:@"."] lastObject] lowercaseString];
}

NSMutableDictionary* get_http_handlers() {
NSArray *handlers =
(__bridge NSArray *) LSCopyAllHandlersForURLScheme(
(__bridge CFStringRef) @"http"
);
NSURL *url = [NSURL URLWithString:@"http://example.com"];
NSArray<NSURL *> *appURLs = [[NSWorkspace sharedWorkspace] URLsForApplicationsToOpenURL:url];

NSMutableDictionary *dict = [NSMutableDictionary dictionary];

for (int i = 0; i < [handlers count]; i++) {
NSString *handler = [handlers objectAtIndex:i];
dict[app_name_from_bundle_id(handler)] = handler;
for (NSURL *appURL in appURLs) {
NSBundle *bundle = [NSBundle bundleWithURL:appURL];
NSString *bundleId = [bundle bundleIdentifier];
if (bundleId) {
dict[app_name_from_bundle_id(bundleId)] = bundleId;
}
}

return dict;
}

NSString* get_current_http_handler() {
NSString *handler =
(__bridge NSString *) LSCopyDefaultHandlerForURLScheme(
(__bridge CFStringRef) @"http"
);
NSURL *url = [NSURL URLWithString:@"http://example.com"];
NSURL *appURL = [[NSWorkspace sharedWorkspace] URLForApplicationToOpenURL:url];

if (appURL) {
NSBundle *bundle = [NSBundle bundleWithURL:appURL];
NSString *bundleId = [bundle bundleIdentifier];
if (bundleId) {
return app_name_from_bundle_id(bundleId);
}
}

return app_name_from_bundle_id(handler);
return nil;
}

void set_default_handler(NSString *url_scheme, NSString *handler) {
Expand All @@ -43,7 +51,7 @@ void set_default_handler(NSString *url_scheme, NSString *handler) {
}

int main(int argc, const char *argv[]) {
const char *target = (argc == 1) ? '\0' : argv[1];
const char *target = (argc == 1) ? NULL : argv[1];

@autoreleasepool {
// Get all HTTP handlers
Expand All @@ -52,7 +60,7 @@ int main(int argc, const char *argv[]) {
// Get current HTTP handler
NSString *current_handler_name = get_current_http_handler();

if (target == '\0') {
if (target == NULL) {
// List all HTTP handlers, marking the current one with a star
for (NSString *key in handlers) {
char *mark = [key caseInsensitiveCompare:current_handler_name] == NSOrderedSame ? "* " : " ";
Expand Down