-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix a few typos in comments #21525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few typos in comments #21525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bzamecnik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the overall quality and clarity of the Keras codebase by fixing a collection of typos found in comments and documentation strings. The changes are purely textual and do not alter any functional behavior of the code, but rather make the explanations and internal notes more accurate and professional.
Highlights
- Comment Clarity: Corrected various spelling errors and grammatical mistakes within code comments and docstrings across multiple Keras modules, enhancing readability and accuracy.
- Consistency in Terminology: Standardized terms like 'traceable' (from 'tracable'), 'flash attention' (from 'flase attention'), and 'uprank' (from 'unprank') for improved consistency.
- Metric Calculation Explanations: Fixed typos in comments explaining complex metric calculations, such as 'examples' (from 'exampless'), 'overestimation' (from 'overstimation'), and 'scaling_factor' (from 'scaling_facor').
- Internal Code Documentation: Addressed minor typos in internal testing utilities, functional model descriptions, and backend-specific notes, ensuring clearer internal documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes several typos in comments across the codebase. The changes are mostly correct. I've pointed out one instance where a typo fix seems to have incorrectly changed the meaning of a comment in a test file.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21525 +/- ##
=======================================
Coverage 82.72% 82.72%
=======================================
Files 567 567
Lines 56245 56245
Branches 8790 8790
=======================================
Hits 46527 46527
Misses 7561 7561
Partials 2157 2157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Credits: PyCharm spellchecker