Skip to content

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Apr 8, 2025

Originally implemented by Divum Gupta, then heavily modified by https://github.com/soten355 into MetalDiffusion.

Finally, I extracted out the TensorFlow variant and converted it to Keras 3.

TODO: test!

@sachinprasadhs
Copy link
Collaborator

Thanks for the PR.

Few general comments which needs to be addressed in this PR.

  • Keep all the files under same model folder to maintain flat folder structure which we follow in Keras Hub
  • Remove all ReadMe.md files, if the details are necessary, add it as part of docstring description.
  • Use only absolute imports, no relative imports.
  • Remove all the Copyright mentions.
  • Remove KerasCV usage in the file names and in the class/method names.
  • Keep the file names all lower case and avoid generic naming usage like layers.py, tools.py etc
  • Follow functional model, refer to our usual design practice we follow for the models here https://github.com/keras-team/keras-hub/tree/master/keras_hub/src/models

Copy link

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@sachinprasadhs
Copy link
Collaborator

Let me know once PR is ready for next round of review.

@divyashreepathihalli
Copy link
Collaborator

@SamuelMarks I see that there have been no updates on this for a while, do you plan on completing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants