UI polish - #147
Closed
myhaksown wants to merge 10 commits into
Closed
Conversation
… adjustments to the existing animation.
… the buttons up above the home bar. Sits a bit further down on devices with a home button. Dynamic placement based on safe area.
…rger target area for grabbing to make it easier to use.
…cy on different device sizes.
Fixes the white corners in screenshots by extending the background a bit further
Author
|
Commit C858E4C fixes the white showing in the PlayerView screenshot of pull request #146. Should be fixed for all device sizes but if not I can adjust it. |
Author
|
Closing in favor of PR# 146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Either Xcode or thru my mistake, this is not as clean as I intended, I apologize.
The rectangle drag bars are now swapped to proper drag handlers with easier to grab targets.
Adjusts the dismiss distance for the PlayerView
Removes some hard coded sizing of various objects. Should improve consistency on devices of various sizes.
Duplicated items
-Fix for the floating player view location
-Airplay button text and distance above screen
-Larger seek target
-floating player view animations