Skip to content

feat(activity): group activity by branch#978

Open
prateek wants to merge 1 commit into
kenn-io:mainfrom
prateek:split-branch-activity-rollups
Open

feat(activity): group activity by branch#978
prateek wants to merge 1 commit into
kenn-io:mainfrom
prateek:split-branch-activity-rollups

Conversation

@prateek

@prateek prateek commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Activity reports now include an activity-specific branch breakdown, filling the grouping piece that the shared branch filter foundation left to each view. The new by_branch rows are keyed by typed project and branch fields, so same-named branches in different projects stay separate and the API does not expose the internal filter token as a grouping key.

The CLI report prints a By branch section. The web Activity page adds a branch typeahead and a Branch breakdown panel, with the activity store loading branch options itself so the page can deep-link and refresh without depending on another view.

Activity page filtered to one branch, with the Branch breakdown panel (synthetic data)

SQLite, PostgreSQL, and DuckDB all carry the same by_branch shape. Empty branches remain distinct from a literal branch named unknown; reviewers should look at the activity aggregation path, the three read backends, and the Activity page breakdown wiring.

Part of #928

@roborev-ci

roborev-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (8e778e2)

Medium issue remains.

Medium

  • docs/session-api.md:602 - The docs describe git_branch as a branch value requiring project, but the server still expects the opaque (project, branch) token from /api/v1/branches. Callers following the doc will get no rows because separator-less branch values decode to an always-false predicate. Restore the /api/v1/branches token documentation and describe git_branch as the opaque returned token, or change the backend to accept literal project + branch parameters.

Reviewers: 2 done | Synthesis: codex, 11s | Total: 7m6s

@prateek prateek changed the title feat(activity): add branch rollups feat(activity): group activity by branch Jul 3, 2026
@prateek prateek force-pushed the split-branch-activity-rollups branch from 8e778e2 to 10b6e57 Compare July 3, 2026 07:59
@prateek

prateek commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the automated review finding: the git_branch row in docs/session-api.md now documents the opaque (project, branch) token format from GET /api/v1/branches instead of implying a plain branch name.

@roborev-ci

roborev-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (10b6e57)

Summary verdict: no Medium, High, or Critical findings to report.

Review 1 reported only a Low-severity docs issue, and Review 2 found no issues.


Reviewers: 2 done | Synthesis: codex, 5s | Total: 6m6s

Adds branch as a rollup dimension to activity reports: by_branch rows
alongside by_project/by_model/by_agent, aggregated identically in
SQLite, Postgres, and DuckDB with parity tests. Rows carry typed
project and branch fields, so same-named branches in different
projects stay distinct and no internal token encoding leaks into the
JSON.

Surfaces: a "By branch" section in the CLI activity report, and a
Branch typeahead plus Branch breakdown panel on the web Activity page.
The activity store fetches its own branch list from the /branches
endpoint, so the page filter works standalone.
@prateek prateek force-pushed the split-branch-activity-rollups branch from 10b6e57 to d6707d2 Compare July 3, 2026 08:52
@roborev-ci

roborev-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (d6707d2)

No medium-or-higher severity findings were reported.

Review 1 only reported a Low severity documentation issue, which is omitted per the requested threshold. Review 2 found no issues.


Reviewers: 2 done | Synthesis: codex, 5s | Total: 8m43s

@prateek prateek marked this pull request as ready for review July 3, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant