fix(usage): wire agent exclusions through usage filters#972
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
d24a85e to
55469df
Compare
|
Addressed the automated review finding: agent exclusions now round-trip through the URL ( |
roborev: Combined Review (
|
55469df to
cd64f5f
Compare
|
Addressed the round-2 finding: UsagePage now calls |
roborev: Combined Review (
|
…opdown Clicking an Agent tile in the Attribution panel updated excludedAgents locally but baseParams() never copied it into the outgoing request, so the exclusion was a silent no-op; hasActiveFilters ignored it too. There was also no Agent FilterDropdown on the Usage toolbar, so hidden agents had no visible surface at all. Wire excludeAgent into baseParams and hasActiveFilters, and add the Agent dropdown mirroring Project's.
cd64f5f to
cbe9a6a
Compare
|
Addressed the round-3 finding: |
roborev: Combined Review (
|
Fixes the pre-existing silent no-op where clicking an agent in Usage attribution updated local exclusion state, but the next usage requests did not send
excludeAgent. The store now includes agent exclusions in the shared request params and counts them inhasActiveFilters, so the API sees the same filter state the UI shows.The Usage toolbar also gets the Agent dropdown next to Project and Model. It uses the existing dropdown pattern, which makes agent exclusions visible and reversible without relying on attribution-row clicks. This stays scoped to Usage agent filtering and does not depend on the branch-dimension work.
Reviewers should start with
frontend/src/lib/stores/usage.svelte.ts;UsagePage.svelteis the toolbar wiring, and the added component/store tests cover the request params plus the attribution-click path.Fixes #976.