feat(i18n): add Korean (ko) locale support#1002
Merged
Merged
Conversation
Add a Korean message catalog and wire the ko locale through the i18n runtime and the language settings UI. - Add frontend/messages/ko.json with the full translated key set, mirroring the zh catalogs' single-variant structure for plural messages (Korean has no plural distinction) - Register ko in project.inlang/settings.json and in SUPPORTED_LOCALES - Match ko and ko-* browser tags in normalizeLocale - Add the Korean option to LanguageSettings and a settings_language_korean key across the en, zh-CN, and zh-TW catalogs - Extend the i18n tests for the locale list, normalization, key alignment, and ko rendering/plural variants
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1001.
Adds a Korean (
ko) locale alongside the existing English and Chinese catalogs.What changed
frontend/messages/ko.json(new): full Korean catalog, key set aligned 1:1 withen. Plural messages mirror the Chinese catalogs' single-variant (countPlural=other) structure because Korean has no plural distinction; all{placeholder}tokens and escaped braces are preserved verbatim.project.inlang/settings.json:koadded tolocales.src/lib/i18n/index.ts:koadded toSUPPORTED_LOCALES;normalizeLocalenow matcheskoandko-*browser tags.src/lib/components/settings/LanguageSettings.svelte: Korean option added to the language picker.messages/{en,zh-CN,zh-TW}.json: newsettings_language_koreanlabel key, keeping all catalogs in sync per theAGENTS.mdlocalization contract.src/lib/i18n/i18n.test.ts: extended for the locale list,konormalization, key alignment across all catalogs, andkorendering / plural-variant selection.Where to look
The translation quality and the plural-structure parity with the zh catalogs are the main review surface.
normalizeLocalefollows the same shape as the existingzh-CN/zh-TWbranches.