Add support for fields with Set(value T). #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is most useful for generic "wrapper" types that add behavior to a contained value. These kinds of wrappers can be useful for configuration values: - A wrapper for sensitive values with protections against printing or logging. - A wrapper integrating with a scheme for dynamic configuration changes. The desirable behavior for a wrapper containing a value of type T is for the envconfig facilities to apply for decoding the contained value. Achieving this behavior today requires duplicating much of the logic in `processField` in a custom `Decode` method on the wrapper, in order to handle all the various types of values that might be contained. Instead, this commit introduces support for abitrary Set(value T) methods by first decoding into a new T and then calling the Set method.
Author
|
Ping @kelishightower @teepark |
1 similar comment
Author
|
Ping @kelishightower @teepark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most useful for generic "wrapper" types that add behavior to a contained value.
These kinds of wrappers can be useful for configuration values:
The desirable behavior for a wrapper containing a value of type T is for the envconfig facilities to apply for decoding the contained value. Achieving this behavior today requires duplicating much of the logic in
processFieldin a customDecodemethod on the wrapper, in order to handle all the various types of values that might be contained.Instead, this commit introduces support for arbitrary Set(value T) methods by first decoding into a new T and then calling the Set method.