ignore warnings at import time in astrometry.net#18
Open
keflavich wants to merge 1 commit into
Open
Conversation
Owner
Author
|
this wasn't supposed to be a PR onto my own branch, but after thinking more, I don't think we should make this change |
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 67.05% 67.05%
=======================================
Files 411 411
Lines 27212 27212
=======================================
Hits 18248 18248
Misses 8964 8964
Continue to review full report at Codecov.
|
no, I don't think we should suppress this warning. Users should do it on their end, or rather get an API key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses issue astropy#1544 by explicitly ignoring warnings when the instance of the astrometry.net class is created at import time.