fix(step): safely unwrap single foreach item when resolving to falsy scalar (#6721) - #6819
Open
MyDude92 wants to merge 2 commits into
Open
fix(step): safely unwrap single foreach item when resolving to falsy scalar (#6721)#6819MyDude92 wants to merge 2 commits into
MyDude92 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6721
📑 Description
Step._get_foreach_itemspreviously used the Python ternary anti-patternreturn len(foreach_items) == 1 and foreach_items[0] or zip(*foreach_items). When a singleforeachreference legitimately evaluates to0orFalse, the expression falls through tozip(*foreach_items)which raisesTypeError: Value after * must be an iterable, not int / bool.Changes Made
keep/step/step.py: Replaced anti-pattern with standard conditional expression:return foreach_items[0] if len(foreach_items) == 1 else zip(*foreach_items).tests/test_steps.py: Added unit testtest_get_foreach_items_falsy_scalarvalidating singleforeachevaluation when resolved context yields0orFalse.✅ Checks