Skip to content

fix: raise when all SignalFx incidents fail to format - #6775

Open
DragonBot00 wants to merge 2 commits into
keephq:mainfrom
DragonBot00:fix/signalfx-empty-alerts
Open

DragonBot00 wants to merge 2 commits into
keephq:mainfrom
DragonBot00:fix/signalfx-empty-alerts

Conversation

@DragonBot00

Copy link
Copy Markdown
Contributor

Problem

SignalFx _get_alerts silently returns [] when every incident fails to format. This masks errors — callers get an empty list with no indication that something went wrong. Other providers (VictoriaMetrics, Prometheus, Dynatrace) raise on total failure.

Fix

Track the total number of incidents and how many failed to format. If all incidents fail, raise an exception instead of silently returning an empty list. Partial failures still return successfully (matching the existing per-item skip pattern used by Datadog and others).

Fixes #6674

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.46%. Comparing base (ce302f6) to head (eecf425).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
keep/rulesengine/rulesengine.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6775       +/-   ##
===========================================
- Coverage   46.42%   30.46%   -15.97%     
===========================================
  Files         178      101       -77     
  Lines       18694    11775     -6919     
===========================================
- Hits         8679     3587     -5092     
+ Misses      10015     8188     -1827     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignalFx _get_alerts returns [] when every incident fails to format — VictoriaMetrics raises

1 participant