fix: raise when all SignalFx incidents fail to format - #6775
Open
DragonBot00 wants to merge 2 commits into
Open
DragonBot00 wants to merge 2 commits into
DragonBot00 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6775 +/- ##
===========================================
- Coverage 46.42% 30.46% -15.97%
===========================================
Files 178 101 -77
Lines 18694 11775 -6919
===========================================
- Hits 8679 3587 -5092
+ Misses 10015 8188 -1827 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SignalFx
_get_alertssilently returns[]when every incident fails to format. This masks errors — callers get an empty list with no indication that something went wrong. Other providers (VictoriaMetrics, Prometheus, Dynatrace) raise on total failure.Fix
Track the total number of incidents and how many failed to format. If all incidents fail, raise an exception instead of silently returning an empty list. Partial failures still return successfully (matching the existing per-item skip pattern used by Datadog and others).
Fixes #6674