-
Notifications
You must be signed in to change notification settings - Fork 992
feat: auto-downgrading revision #4678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: auto-downgrading revision #4678
Conversation
@EnotShow is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
hey @EnotShow - thanks for this PR! as this PR introduces some major changes to how Keep works, I thought I would add some e2e tests for it (mainly install Keep, do some migration, then downgrade). wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4678 +/- ##
==========================================
- Coverage 46.19% 46.03% -0.16%
==========================================
Files 165 165
Lines 17495 17564 +69
==========================================
+ Hits 8081 8086 +5
- Misses 9414 9478 +64 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
β¦EnotShow/keep into feature/auto-downgrade-revision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
β¦EnotShow/keep into feature/auto-downgrade-revision
Deployment failed with the following error:
|
β¦EnotShow/keep into feature/auto-downgrade-revision
Hey @shahargl! Thx for your review! I made all the required changes, so it's ready for re-review :) |
@EnotShow let tests pass and if they will I'll review |
Closes #4665
π Description
This PR introduces automatic database downgrading support when rolling back KeepHQ to a previous version.
β Checks
βΉ Additional Information