Skip to content

Conversation

@pranmya
Copy link

@pranmya pranmya commented Jan 7, 2026

Overview

Fixed a UI consistency issue in the "Properties" tab of the entry editor. Previously, the "Remove" button in the Plugin Data section was enabled by default if any data existed, even if no specific row was selected.

Changes

  • Modified EditWidgetProperties::update() in src/gui/EditWidgetProperties.cpp.
  • Updated the logic to check for an active selection in customDataTable instead of just checking if the underlying data container is non-empty.
  • This ensures the "Remove" button remains disabled until the user explicitly selects a row to delete.

Screenshots

[Paste your "Before" and "After" screenshots here by dragging them into the box]

Testing strategy

  • Manual Verification: Built the application on Windows 11 with Qt 5.15.18 and verified that the button state now correctly reflects the selection state.
  • Persistence: Verified the button correctly re-disables after a successful deletion or when the selection is cleared.
  • Regression: Ran ctest to ensure no core logic was affected (95% pass rate, failures were unrelated to this UI change).

Type of change

remove_active remove_inactive

@pranmya pranmya requested a review from droidmonkey January 9, 2026 12:02
@droidmonkey droidmonkey merged commit 6bd8360 into keepassxreboot:release/2.7.x Jan 9, 2026
12 checks passed
@droidmonkey
Copy link
Member

Thanks!

@droidmonkey droidmonkey added this to the v2.7.12 milestone Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants