Support for ablation studies for AddBiomechanics ECCV paper #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbianco
reviewed
May 15, 2024
Collaborator
nickbianco
left a comment
nickbianco
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments to clarify some potential changes to the dynamic fitter algorithm.
| int driftCorrectionBlurRadius = 250, | ||
| int driftCorrectionBlurInterval = 250); | ||
| int driftCorrectionBlurInterval = 250, | ||
| s_t regularizeUnobservedTimesteps = 0.01); |
Collaborator
There was a problem hiding this comment.
The default value for regularizeUnobservedTimesteps was changed from 0.1 to 0.01 here -- will that have any meaningful effect on the dynamics fitter algorithm?
|
|
||
| // Now that we've formulated our problem, we can attempt to solve: | ||
|
|
||
| // Eigen::VectorXs tentativeResult = |
Collaborator
There was a problem hiding this comment.
Remove all this commented out code?
| if (maxIterations > 1000) | ||
| { | ||
| maxIterations = 1000; | ||
| } |
Collaborator
There was a problem hiding this comment.
Capping at a 1000 iterations shouldn't change much right? This usually converges in a handful of iterations if everything is set up right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a few methods we needed in order to run some ablation tests requested by reviewers for ECCV. A few small GUI optimization fixes also got wrapped up in this PR.