Open
Conversation
Develop -> Main for 5.5.0 release
Collaborator
Author
|
There is probably a better file for this code... but its a POC |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3707 +/- ##
========================================
Coverage 25.96% 25.97%
========================================
Files 461 461
Lines 46691 46696 +5
========================================
+ Hits 12122 12127 +5
Misses 34569 34569
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of PR purpose/changes
This PR introduces an override of the
window.alertwhich suppress alerts and prints them to console.error with a stacktrace (it can be hard to trace what made the alert call otherwise, because it becomes non-blocking)This should fix the issues with datatables throwing ui alerts instead of errors from the clustering app.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/SCT-3097
Testing Instructions
Dev Checklist:
formatandcheckon changed Python code manually or with a git precommit hookUpdating Version and Release Notes (if applicable)