Conversation
3s is not enough if the image is pulling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 97.75% 98.33% +0.58%
==========================================
Files 1 1
Lines 89 120 +31
==========================================
+ Hits 87 118 +31
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently no test where the _call method returns a list of arguments because I can't think of any services, dynamic or normal, that do that
briehl
left a comment
briehl
left a comment
There was a problem hiding this comment.
Just a couple questions / comments. I'm approving anyway.
| import requests as _requests | ||
| import os as _os | ||
| from urllib.parse import urlparse as _urlparse | ||
| import time as _time |
There was a problem hiding this comment.
Why the underscore imports? Sticking to previous convention?
There was a problem hiding this comment.
yeah, that's how it is in the original client. it's actually not a bad practice as it keeps the namespace cleaner for introspection and other use cases
src/kbase/sdk_baseclient.py
Outdated
|
|
||
|
|
||
| # tested this manually by shortening _EXP_BACKOFF_MS and adding printouts below | ||
| def _get_next_backoff(backoff_index: int = 1): |
| * Serializing set and frozenset | ||
| * Methods that return a list vs. a single value (save_objects). | ||
| """ | ||
| # TODO add test for service that returns > 1 value. Not sure if any services do this |
There was a problem hiding this comment.
AFAICT there aren't any. But it's possible to have them, so I guess just leave the TODO for now.
There was a problem hiding this comment.
yeah, if it comes to it I'll mock one. But if no services are doing it, then not testing it isn't really a huge issue
2 participants
No description provided.