Merged
Conversation
Tianhao-Gu
approved these changes
Feb 6, 2026
test_update_job_and_subjob_fail_update_to_error keeps failing on the subjob test because it doesn't throw an exception. I can't reproduce this locally, so I'm guessing it's a timing issue...? Seems iffy if an update isn't applied by the time the call returns
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 69 69
Lines 5897 5897
=======================================
Hits 3148 3148
Misses 2749 2749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No idea how that test passed at all or why I didn't get warnings that an async method wasn't awaited. Maybe the client is doing something weird under the hood?
Tianhao-Gu
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix tests that were passing locally but not on GHA. It turns out that
motorfunctions aren't realasyncfunctions and will run before beingawaited and won't warn if you don'tawaitthem