Add warnings for abnormal values#110
Merged
Merged
Conversation
fc1245d to
c4bd6ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the grid editor so that values outside of a specific range per measure are highlighted. The goal of this is to proactively show the user where they may have entered some wrong data.
Screenshots/Videos (if applicable)
Invalid value (absolute min/ max)
This functionality already exists, if a value is out of its logical min/max values we validate it on the UI and prevent it from being saved.
Abnormal value (suggested min/max)
If a value is outside the suggested bounds, we save it as normal but display a warning sign next to the value.
Requirements, dependencies and related PRs
The backend is still a WIP, the min/ max values have been mocked and this shouldn't be merged until the backend is ready.
✅ Pre-Merge Checklist
Type of Change
Testing
Manual testing instructions
If feature requires manual testing by reviewer, you can provide instructions here.Internationalization & Accessibility
Dependencies