Skip to content

Add warnings for abnormal values#110

Merged
woodwoerk merged 3 commits into
mainfrom
feat/add-warnings-for-abnormal-values
Apr 30, 2026
Merged

Add warnings for abnormal values#110
woodwoerk merged 3 commits into
mainfrom
feat/add-warnings-for-abnormal-values

Conversation

@woodwoerk
Copy link
Copy Markdown
Collaborator

Description

Update the grid editor so that values outside of a specific range per measure are highlighted. The goal of this is to proactively show the user where they may have entered some wrong data.

Screenshots/Videos (if applicable)

Invalid value (absolute min/ max)

This functionality already exists, if a value is out of its logical min/max values we validate it on the UI and prevent it from being saved.

image

Abnormal value (suggested min/max)

If a value is outside the suggested bounds, we save it as normal but display a warning sign next to the value.

image

Requirements, dependencies and related PRs

The backend is still a WIP, the min/ max values have been mocked and this shouldn't be merged until the backend is ready.


✅ Pre-Merge Checklist

Type of Change

  • Set the PR's label to match the nature of this change

Testing

  • Built Unit tests (unit tests added/updated)
  • Authorization is tested (permissions and access controls verified)
  • Mobile screen widths tested for responsiveness (if applicable)
  • Manually tested locally in all affected projects (functionality verified)
    Manual testing instructions
    If feature requires manual testing by reviewer, you can provide instructions here.

Internationalization & Accessibility

  • Accessibility standards met (WCAG compliance, screen reader support)

Dependencies

  • Dependencies are merged (if applicable. If the change depends on other PRs)

@woodwoerk woodwoerk requested a review from lilia1891 April 28, 2026 11:55
@woodwoerk woodwoerk added the New feature New feature (non-breaking change which adds functionality) label Apr 28, 2026
Copy link
Copy Markdown
Contributor

@lilia1891 lilia1891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@woodwoerk woodwoerk force-pushed the feat/add-warnings-for-abnormal-values branch from fc1245d to c4bd6ec Compare April 29, 2026 12:20
@woodwoerk woodwoerk marked this pull request as ready for review April 30, 2026 06:34
@woodwoerk woodwoerk merged commit c73839e into main Apr 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New feature New feature (non-breaking change which adds functionality)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants