Gate indicator goal-met tick on column block flag#612
Conversation
Bhavatu
added
the
New feature
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e636fdb25
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Bhavatu
force-pushed
the
feat/indicator_value_highlight_goal_met_toggle
branch
2 times, most recently
from
93d57dc to
4587568
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 62.66% 62.67%
=======================================
Files 387 387
Lines 40983 40991 +8
Branches 5238 5239 +1
=======================================
+ Hits 25684 25691 +7
- Misses 13689 13691 +2
+ Partials 1610 1609 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Bhavatu
force-pushed
the
feat/indicator_value_highlight_goal_met_toggle
branch
from
4587568 to
72a0085
Compare
Bhavatu
force-pushed
the
feat/indicator_value_highlight_goal_met_toggle
branch
from
97faa7b to
2bd289e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bd289e9f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("pages", "0068_alter_categorypage_body_alter_planrootpage_body_and_more"), |
There was a problem hiding this comment.
Because pages/migrations/0069_add_front_page_hero_additional_settings.py already exists in the parent and also depends on 0068, adding this new 0069 from the same dependency creates a second migration branch in the pages app. Even though 0070_preserve_indicator_value_highlight_goal_met follows this branch, the app still has two leaf nodes (0069_add_front_page_hero_additional_settings and 0070_preserve_indicator_value_highlight_goal_met), so Django will stop with a conflicting-migrations error before applying migrations. Please renumber/rebase this chain so it depends on the existing 0069.
Useful? React with 👍 / 👎.
Add highlight_goal_met BooleanBlock to IndicatorValueColumn so admins can toggle the goal-achieved tick on the latest-value column. New blocks default to True; a Wagtail StreamField data migration flips existing value blocks to False so previously deployed plans keep their current behaviour and customers can opt in per column from the admin.
Bhavatu
force-pushed
the
feat/indicator_value_highlight_goal_met_toggle
branch
from
2bd289e to
f976d51
Compare
2 participants
Description
Add highlight_goal_met BooleanBlock to IndicatorValueColumn so admins can toggle the goal-achieved tick on the latest-value column.
New blocks default to True; a Wagtail StreamField data migration flips existing value blocks to False so previously deployed plans keep their current behaviour and customers can opt in per column from the admin.
Flag only available for value type == "latest value"
Screenshots/Videos (if applicable)
Related issue
https://app.asana.com/1/1201243246741462/project/1206017643443542/task/1214566034369730
Requirements, dependencies and related PRs
Frontend: kausaltech/kausal-watch-ui#763
Conditional visibility of the field depends on this: kausaltech/kausal-backend-common#92
Additional Notes
Any additional information that reviewers should know about this PR.
✅ Pre-Merge Checklist
Type of Change
Testing
Manual testing instructions
If feature requires manual testing by reviewer, you can provide instructions here.Internationalization & Accessibility
Integrations (if applicable)
If there are model changes to models which use any of the features below, verify the new models work together with the features.
For example, when adding a new model, verify the new model instances are copied when copying a plan.
Dependencies