New widget SelectableLabel; use ScrollComponent in ScrollLabel, EditBox #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves ScrollLabel with an unused field and unnecessary type parameter; a small cost for the code saved. (Label is used so frequently and is sufficiently simple that it would not make sense to merge with Text in the same way.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how
ScrollLabel,ScrollText,EditBoxhandle scrolling: these now all use aScrollComponentin the outer widget and do not support scrolling in the inner widget.SelectableLabelwas added as the new inner widget ofScrollLabel.ScrollLabelandScrollTextwere merged into a single widget. This also fixes the inaccurate usage ofRolein #519.TextInputcomponent no longer handles kinetic scrolling and better tracks the current action "phase".Fixes:
fn Tile::translationnow takes argumentindex, allowing per-child translation. This is required for the newScrollLabel,EditBoxbut also allowstranslationto more accurately match AccessKit.fn EditField::set_outer_rectEditField. (We still don't replace explicit new-lines in the text when rendering though, like most single-line edit widgets do.)EditField: use the text height when available but also use Em size as a backup for empty fields or requesting excess size. The real fix is... well, there isn't really one considering we don't know what fonts might be used as a fallback and what glyph heights they might use.child_rectallocation inScrollRegion. (Not properly tested but I'm pretty sure the old code was wrong.)