-
Notifications
You must be signed in to change notification settings - Fork 149
Get GongJiKeJi on boarding #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get GongJiKeJi on boarding #920
Conversation
Summary of ChangesHello @XiShanYongYe-Chang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates GongJiKeJi as a new adopter into the project's documentation. The changes involve updating both the Chinese and English adopter lists with GongJiKeJi's information and adding their logo to the supporters' data, thereby expanding the public record of organizations leveraging Karmada. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds GongJiKeJi as a new adopter of Karmada. The changes include updating the adopters list in both English and Chinese documentation, and adding the company's logo to the supporters data. The changes are mostly correct, but I've found a minor grammatical issue and a trailing whitespace in the English adopters file that should be addressed for consistency and correctness.
Signed-off-by: changzhen <[email protected]>
5da646a to
4a01ea4
Compare
|
Hi @guquanheng, can you help take a review? |
|
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: guquanheng. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/kind feature |
windsonsea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/remove-kind feature |
|
/kind feature |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Get GongJiKeJi on boarding.
Which issue(s) this PR fixes:
Part of karmada-io/community#163
Special notes for your reviewer: