Skip to content

Conversation

@zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Unified cmdinit CI: Consolidates init-related tests from ci.yml and installation-cli.yaml into a single, comprehensive e2e test suite, streamlining the testing process.
New Base E2E Test: Introduces base_test.go to cover the full lifecycle of a Karmada instance, including installation, member cluster joining, and basic resource propagation, ensuring core functionality is validated.

Which issue(s) this PR fixes:

Part of #6887

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 14, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng, xishanyongye-chang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors and enhances the end-to-end testing for the karmadactl init command. The primary goal is to create a more robust and maintainable testing framework by unifying existing tests and introducing a new comprehensive base test. This ensures that the entire Karmada instance lifecycle, from initial setup to basic resource propagation, is thoroughly validated in an automated fashion, improving the reliability of the initialization process.

Highlights

  • Unified E2E Test Suite: Consolidated init-related tests from ci.yml and installation-cli.yaml into a single, comprehensive end-to-end test suite for karmadactl init, streamlining the testing process.
  • New Base E2E Test: Introduced base_test.go to cover the full lifecycle of a Karmada instance, including installation, member cluster joining, and basic resource propagation, ensuring core functionality is validated.
  • Environment Setup Refactoring: Refactored hack/init-e2e-environment.sh to leverage hack/setup-dev-base.sh, simplifying the script and promoting reusability for development environment setup.
  • Test Script Updates: Updated hack/run-e2e-init.sh to align with the new unified E2E suite, including changes to environment variable names and the ginkgo command execution.
  • Improved Test Isolation: Enhanced test isolation in test/e2e/suites/init by introducing global variables for karmadaDataPath and karmadaAPIServerNodePort, ensuring unique temporary directories and ports for each test run.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/ci.yml
    • .github/workflows/installation-cli.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the cmdinit E2E test environment to unify it with the CI process. The changes primarily involve simplifying init-e2e-environment.sh by moving common setup logic to setup-dev-base.sh, and updating the Go test files for better structure and clarity. My review focuses on ensuring the refactored scripts work as intended. I've identified a critical issue where a required test file is no longer placed in the correct directory, which would likely break the E2E tests. I've also noted a couple of minor typos in a script's copyright header and in the new README file. Overall, the refactoring is a good improvement, and with the suggested fixes, it should be solid.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.39%. Comparing base (e2c4b59) to head (24aea95).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6928      +/-   ##
==========================================
- Coverage   46.39%   46.39%   -0.01%     
==========================================
  Files         698      698              
  Lines       47763    47763              
==========================================
- Hits        22162    22159       -3     
- Misses      23932    23935       +3     
  Partials     1669     1669              
Flag Coverage Δ
unittests 46.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2025
@zhzhuang-zju
Copy link
Contributor Author

cc @luyb177

Signed-off-by: zhzhuang-zju <[email protected]>
@zhzhuang-zju
Copy link
Contributor Author

@luyb177 Thanks~ All done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants