-
Notifications
You must be signed in to change notification settings - Fork 1k
unify cmdinit E2E and CI #6928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
unify cmdinit E2E and CI #6928
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors and enhances the end-to-end testing for the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the cmdinit E2E test environment to unify it with the CI process. The changes primarily involve simplifying init-e2e-environment.sh by moving common setup logic to setup-dev-base.sh, and updating the Go test files for better structure and clarity. My review focuses on ensuring the refactored scripts work as intended. I've identified a critical issue where a required test file is no longer placed in the correct directory, which would likely break the E2E tests. I've also noted a couple of minor typos in a script's copyright header and in the new README file. Overall, the refactoring is a good improvement, and with the suggested fixes, it should be solid.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6928 +/- ##
==========================================
- Coverage 46.39% 46.39% -0.01%
==========================================
Files 698 698
Lines 47763 47763
==========================================
- Hits 22162 22159 -3
- Misses 23932 23935 +3
Partials 1669 1669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @luyb177 |
Signed-off-by: zhzhuang-zju <[email protected]>
|
@luyb177 Thanks~ All done |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Unified cmdinit CI: Consolidates init-related tests fromci.ymlandinstallation-cli.yamlinto a single, comprehensive e2e test suite, streamlining the testing process.New Base E2E Test: Introducesbase_test.goto cover the full lifecycle of a Karmada instance, including installation, member cluster joining, and basic resource propagation, ensuring core functionality is validated.Which issue(s) this PR fixes:
Part of #6887
Special notes for your reviewer:
Does this PR introduce a user-facing change?: