Skip to content

flaky test: application failover with purgeMode gracefully when the GracePeriodSeconds is reach out #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
+9 −1
Merged

flaky test: application failover with purgeMode gracefully when the GracePeriodSeconds is reach out #6917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/e2e/suites/base/failover_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ var _ = ginkgo.Describe("application failover testing", func() {
var policy *policyv1alpha1.PropagationPolicy
var maxGroups, minGroups int
var gracePeriodSeconds, tolerationSeconds int32
var targetClusters []string

ginkgo.BeforeEach(func() {
policyNamespace = testNamespace
Expand All @@ -315,6 +316,7 @@ var _ = ginkgo.Describe("application failover testing", func() {
deployment = testhelper.NewDeployment(deploymentNamespace, deploymentName)
maxGroups = 1
minGroups = 1
targetClusters = framework.ClusterNames()[:2]

policy = &policyv1alpha1.PropagationPolicy{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -331,7 +333,7 @@ var _ = ginkgo.Describe("application failover testing", func() {
},
Placement: policyv1alpha1.Placement{
ClusterAffinity: &policyv1alpha1.ClusterAffinity{
ClusterNames: framework.ClusterNames()[:2],
ClusterNames: targetClusters,
},
SpreadConstraints: []policyv1alpha1.SpreadConstraint{
{
Expand Down Expand Up @@ -372,6 +374,9 @@ var _ = ginkgo.Describe("application failover testing", func() {

ginkgo.It("application failover with purgeMode gracefully when the application come back to healthy on the new cluster", func() {
disabledClusters := framework.ExtractTargetClustersFromRB(controlPlaneClient, deployment.Kind, deployment.Namespace, deployment.Name)
framework.WaitDeploymentPresentOnClustersFitWith(disabledClusters, deployment.Namespace, deployment.Name, func(deployment *appsv1.Deployment) bool {
return framework.CheckDeploymentReadyStatus(deployment, *deployment.Spec.Replicas)
})
ginkgo.By("create an overridePolicy to make the application unhealthy", func() {
overridePolicy := testhelper.NewOverridePolicyByOverrideRules(policyNamespace, policyName, []policyv1alpha1.ResourceSelector{
{
Expand Down Expand Up @@ -445,6 +450,9 @@ var _ = ginkgo.Describe("application failover testing", func() {
})

disabledClusters := framework.ExtractTargetClustersFromRB(controlPlaneClient, deployment.Kind, deployment.Namespace, deployment.Name)
framework.WaitDeploymentPresentOnClustersFitWith(disabledClusters, deployment.Namespace, deployment.Name, func(deployment *appsv1.Deployment) bool {
return framework.CheckDeploymentReadyStatus(deployment, *deployment.Spec.Replicas)
})
var beginTime time.Time
ginkgo.By("create an overridePolicy to make the application unhealthy", func() {
overridePolicy := testhelper.NewOverridePolicyByOverrideRules(policyNamespace, policyName, []policyv1alpha1.ResourceSelector{
Expand Down